fix: remove hardcoded resolution selector #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice work, thank you for the testing. LGTM! 👏 |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…ally (mrousavy#2997) * fix: remove hardcoded resolution selector * fix: remove unused import --------- Co-authored-by: Maksim Efimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Hi! I noticed that on Android barcode corners detection works way better without hardcoded resolution selector. On Pixel XL automatically selected resolution is
{"height": 480, "width": 640}vs{"height": 720, "width": 1280}with resolution selectorTested on
Demo
Galaxy tab s9+
Before
video_2024-06-15_19-20-10.mp4
After
video_2024-06-15_19-20-04.mp4
Pixel XL Emulator
Before
2024-06-15.15.59.55.mp4
After
2024-06-15.15.56.50.mp4