Use correct UIManager in findCameraView depending on the architecture
#2702
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WoLewicki
approved these changes
Mar 29, 2024
|
Wow, nice catch man - thank you so much! LGTM 💪 |
wcandillon
reviewed
Apr 4, 2024
| @@ -55,10 +56,11 @@ class CameraViewModule(reactContext: ReactApplicationContext) : ReactContextBase | |||
| suspendCoroutine { continuation -> | |||
| UiThreadUtil.runOnUiThread { | |||
| Log.d(TAG, "Finding view $viewId...") | |||
| val uiManagerType = if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) UIManagerType.FABRIC else UIManagerType.DEFAULT | |||
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…tecture (mrousavy#2702) Fix `findCameraView`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
UIManagerHelper.getUIManagerhas following signature:(Here's the source: https://github.com/facebook/react-native/blob/3f8882116782da609664f311427d7a6523ad06cf/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.java#L51)
But in
findCameraViewit's used like this:react-native-vision-camera/package/android/src/main/java/com/mrousavy/camera/CameraViewModule.kt
Lines 59 to 62 in 8316804
where the view tag is passed instead of the UI manager type. This effectively makes it behave as if
DEFAULTwas passed andUIManagerModulewas returned on the new arch instead ofFabricUIManager.Changes
Tested on
I've only tried on Android emulator
Related issues
Potentially fixes #2613