Skip to content

Conversation

@l2hyunwoo
Copy link
Contributor

스크린샷 2025-10-27 오전 1 35 53 스크린샷 2025-10-27 오전 1 36 47

remove warnings 🔥

@vercel
Copy link

vercel bot commented Oct 26, 2025

@l2hyunwoo is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

@mrousavy
Copy link
Owner

doesn't this break compatibility for older react-native versions?
Nitro promises to support RN 0.75+

@mrousavy
Copy link
Owner

BaseReactPackage was introduced in facebook/react-native#40775.

@mrousavy
Copy link
Owner

Ok so this change is fine, but there a few other places where we need to replace this. e.g. docs.

@mrousavy mrousavy merged commit ac3d8ad into mrousavy:main Oct 27, 2025
3 of 4 checks passed
github-merge-queue bot pushed a commit to callstack/react-native-builder-bob that referenced this pull request Oct 27, 2025
TurboReactPackage is deprecated by RN

<!-- Please provide enough information so that others can review your
pull request. -->
<!-- Keep pull requests small and focused on a single change. -->

### Summary

See mrousavy/nitro#994


<!-- What existing problem does the pull request solve? Can you solve
the issue with a different approach? -->

### Test plan

<!-- List the steps with which we can test this change. Provide
screenshots if this changes anything visual. -->
@l2hyunwoo l2hyunwoo deleted the chore/base-react-package branch October 31, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants