Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "nitrogen" as bin #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kraenhansen
Copy link
Contributor

Merging this will declare the "bin" of "nitro-codegen" as "nitrogen", allowing any package taking on the "nitro-codegen" to execute the local "nitrogen" binary. I've updated docs and usage to the best of my abilities 🤞

Copy link

vercel bot commented Nov 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 1:27pm

@@ -119,22 +119,22 @@ Now run nitrogen:
<Tabs groupId="package-manager">
<TabItem value="npm" label="npm" default>
```sh
npm run nitro-codegen
npx nitrogen
Copy link
Contributor Author

@kraenhansen kraenhansen Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was making assumptions on the existence of a "nitro-codegen" script in the app's package.json, which is not way I believe was the intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant