Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for elixir 1.3 #9

Merged
merged 3 commits into from
Nov 7, 2016
Merged

Conversation

jeffweiss
Copy link
Contributor

No description provided.

Jeff Weiss added 2 commits June 21, 2016 13:42
Prior to this commit exmoji used the old `\x{H*}` format for unicode
escape sequences, which generates warnings with Elixir 1.3. This commit
updates those escape sequences to use the preferred `\xHH` and `\uHHHH`
formats.
@jeffweiss
Copy link
Contributor Author

Hmm. It looks like this fails on Elixir 1.0.5, which only had \x and not \u. Unless I'm missing something, I don't see anything that's compatible with both 1.0.5 and 1.3.0. @mroth, do you have thoughts about increasing the requirement for this lib to 1.1?

@mroth
Copy link
Owner

mroth commented Jun 21, 2016

@jeffweiss Thanks for this! I'm surprised there's nothing that's backwards compatible, since this is considered a semantic versioning minor release rather than major. Perhaps check on IRC to be sure?

That said, while maintaining full 1.x compatibility would be ideal, if there is no way to do it short of branching code, then I personally don't have a problem with bumping the versioning requirement, especially since Elixir is primarily early adopters currently, who are more likely to be on a recent-ish version. (In which case, we would want to update the min supported version in the metadata).

@jeffweiss
Copy link
Contributor Author

@mroth \x{..} still works in 1.3, it just spews a lot of compiler warnings

@mroth mroth merged commit 8d168b0 into mroth:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants