Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mix dependency :poison by :jason #18

Merged
merged 2 commits into from
May 16, 2020
Merged

Replace Mix dependency :poison by :jason #18

merged 2 commits into from
May 16, 2020

Conversation

redrabbit
Copy link
Contributor

A lot of Hex packages (Phoenix and Ecto to name the bigger ones) requiring JSON encoding/decoding have moved to :jason lately.

This PR is a pure replacement, an other possibility would be make the JSON decoder configurable.

@mroth
Copy link
Owner

mroth commented May 14, 2020

Hi, thanks for the contribution! It looks like this is failing tests in Travis CI on version of Elixir < 1.3.0. I'm guessing most folks have moved off those older versions by now?

If so, the travis file can be adjusted to remove those tests, however a new constraint should then be added to this module indicating the minimum version of Elixir required. Thoughts?

@redrabbit
Copy link
Contributor Author

redrabbit commented May 15, 2020

I've updated .travis.yml to use Elixir versions from 1.4 to 1.10 with appropriate OTP versions.

@mroth
Copy link
Owner

mroth commented May 16, 2020

Thanks so much!

@redrabbit
Copy link
Contributor Author

It would be nice to have a newer version published on Hex 😄.

@mroth
Copy link
Owner

mroth commented Jun 14, 2020

@redrabbit it's been a long while since I've published anything via Hex (I dont actually even have Elixir toolchain on my workstation at the moment). Do you know if there is a decent GitHub Action to automate publishing? That way it would be easier to have releases be community maintained. I did find this one but it doesnt have many stars currently: https://github.com/marketplace/actions/publish-to-hex

@redrabbit
Copy link
Contributor Author

Hi @mroth, I'm not really familiar with GH actions. The publish-to-hex action you are referring to seems to do the job.

As a maintainer myself I would not want to have package publication as part of my CI for various reasons. When I release a new version, I have a few steps to do manually.

  • Bump version number in one or multiple files.
  • Add changes to CHANGELOG.
  • Add new Git tag.
  • Deploy/publish package.

After researching for a while, I stumbled across this older comment from @ericmj (author of Hex) who addresses a similar issue.

@mroth
Copy link
Owner

mroth commented Jun 17, 2020

@redrabbit gotcha. I have a number of those things automated in my other repos (often using https://github.com/mroth/bump), but I'll try to just cut the release to Hex manually here in a docker container for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants