Skip to content

Exclude obsolete raw keys from the label registry #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrmps merged 1 commit into from
Sep 23, 2026
Merged

Exclude obsolete raw keys from the label registry #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion e2e/spending.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ try {
await labelStore.put('cls:ls_legacy', '2026-09-01T00:00:00.000Z');
await labelStore.put('cls:ls_malformed', '{broken');
await labelStore.put('unrelated-secret', 'must not appear');
await labelStore.put('cls:obsolete-raw-key', '2026-09-01T00:00:00.000Z');
let next = adminUrl;
const seen = new Set();
const pageSizes = [];
Expand All @@ -51,7 +52,7 @@ try {
assert.match(response.headers.get('cache-control'), /private/);
const html = await response.text();
assert.match(html, /All label sets/);
assert.doesNotMatch(html, /<script>alert|must not appear/);
assert.doesNotMatch(html, /<script>alert|must not appear|obsolete-raw-key/);
const ids = [...html.matchAll(/data-classifier="([^"]+)"/g)].map(match => match[1]);
pageSizes.push(ids.length);
for (const id of ids) { assert.ok(!seen.has(id), 'no duplicate registry rows'); seen.add(id); }
Expand Down
2 changes: 1 addition & 1 deletion src/admin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ ${table("Busiest classifiers", d.topLabels, ["label_names", "labels", "requests"
// ---------------------------------------------------------------- entry

async function classifierRegistry(env: Env, cursor: string) {
const listed = await env.STATS.list({ prefix: "cls:", limit: 50, ...(cursor ? { cursor } : {}) });
const listed = await env.STATS.list({ prefix: "cls:ls_", limit: 50, ...(cursor ? { cursor } : {}) });
const rows = await Promise.all(listed.keys.map(async ({ name }) => {
const raw = await env.STATS.get(name);
let labels: string[] = [];
Expand Down
Loading