-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update micromatch to address CVE-2024-4068 #444
Conversation
fast-glob -> micromatch -> braces: 3.0.2 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-4068
I'm not the maintainer of the package but this change is pretty much unneeded since the current version range already allows for this update... |
Hi, can this change be merged and new version be released. I need to address this CVE in our project as well. |
+1 With this PR 2 high vulnerabilities will be fixed |
Why is it unneeded? |
Thank you for your reply. Unfortunately this version range allowes the unpatched version to be used. This PR enforces the use of the patched version. |
It should help to solve
|
Thanks for the pull request. I don't consider this CVE to be a real threat to anything. I think this comment reflects my personal feelings on the matter. The current pull request updates the dependency in the current branch, which is targeted for the upcoming version (4.x.x). I will try to port the changes to the branch of the current version of the package. And if it succeeds without major breakdowns, I will release a new version (3.x.x). This week. |
Hi @mrmlnc , will we get a 3.x.x with this fix soon? |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fast-glob](https://github.com/mrmlnc/fast-glob) | dependencies | patch | [`3.3.2` -> `3.3.3`](https://renovatebot.com/diffs/npm/fast-glob/3.3.2/3.3.3) | --- ### Release Notes <details> <summary>mrmlnc/fast-glob (fast-glob)</summary> ### [`v3.3.3`](https://github.com/mrmlnc/fast-glob/releases/tag/3.3.3) [Compare Source](mrmlnc/fast-glob@3.3.2...3.3.3) > **Full Changelog**: mrmlnc/fast-glob@3.3.2...3.3.3 #### 💬 Common - Refer to [email protected] to avoid annoying npm audit spam ([#​443](mrmlnc/fast-glob#443), [#​444](mrmlnc/fast-glob#444), [#​454](mrmlnc/fast-glob#454), [#​456](mrmlnc/fast-glob#456), [#​457](mrmlnc/fast-glob#457), [#​461](mrmlnc/fast-glob#461)) #### 🐛 Bug fixes - Apply absolute negative patterns to full path instead of file path ([#​441](mrmlnc/fast-glob#441), thanks [@​webpro](https://github.com/webpro)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTAuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6476 Reviewed-by: Earl Warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
closes #443
What is the purpose of this pull request?
Fix a security vulnerability for
braces
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-4068
What changes did you make? (Give an overview)
Updated one line in packages.json to point to the fixed versions
micromatch/micromatch#249
micromatch/braces#35
--> https://github.com/micromatch/braces/releases/tag/3.0.3