Proposal of changes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying limits of "pasts shows"
New version: · It supports other reddits · Can extract video from different places (not just the 50 top ones from each category). · Decreased the requirement of upvotes. Now as long as it has more upvotes than downvotes is accepted. · Fixed the list of past videos: now the last element is visible. · Code modified so the remote can be supported in older browsers.
Removing now unnecessary alerts.
Adding support to /r/IllBeYourGuide
Adding support to /r/IllBeYourGuide
Fixing error in line 53: using the variable "len_subs" instead of the constant "4"
Adding keyboard control
Fixing behaviour of right arrow
Fixing my stupid mistake with left arrow.
Ok, now left arrow should change the channel. Also supported links to reddit with "R" key.
Adding more source of variety. 50 links are requested, but each one had 14% of chance of being processed.
Changing presentation of the list of previous videos.
Fixing zoomed version of menu.
Modified the help
Added a slider for changing minimum post score, and added /r/CommercialCuts. Also menu is scrollable now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified a bit your web-app so it can support more features. I'm not sure if you like the changes or not, but feel free to use any of the code as you wish. As I wrote in the readme, the changes are:
· Optional support of more subs with similar content can be activated via menu.
> /r/NotTimAndEric,
> /r/ACIDS,
> /r/fifthworldvideos,
> /r/IllBeYourGuide.
If no option is selected, /r/InterdimensionalCable will be used by default.
· New system that increases randomization.
· Softened the score requirement so any video with score ≥ 1 is accepted
(before, the videos with score < 5 were excluded).
· Cosmetic change of the list of previously played videos: now all the elements
should be visible in any browser and screen.
· Keyboard support! Now you can use a wireless keyboard (or joypad using joy2key
or whatever) to watch interdimensional tv!
· The code was modified so the site can be slightly more usable in more devices.
It was tested on Android Lollipop: it presents buggy behavior but is usable,
specially with virtual keyboards like Ivan Volosyuk's "WiFi Keyboard".