Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullable types for trailing lambdas in ComposeParameterOrder #61

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Allow nullable types for trailing lambdas in ComposeParameterOrder #61

merged 1 commit into from
Jun 9, 2023

Conversation

mrmans0n
Copy link
Owner

@mrmans0n mrmans0n commented Jun 9, 2023

Fixes #59

@mrmans0n mrmans0n changed the title Take nullable types into account for trailing lambdas in ComposeParam… Allow nullable types for trailing lambdas in ComposeParameterOrder Jun 9, 2023
@mrmans0n mrmans0n merged commit a36890f into main Jun 9, 2023
mrmans0n added a commit to slackhq/compose-lints that referenced this pull request Jun 9, 2023
@mrmans0n
Allow nullable types for trailing lambdas in ComposeParameterOrder
dcb1d86 
Fixed upstream in mrmans0n/compose-rules#61

Functional types weren't being taken into account when computing the desired order of parameters in composables when the function was nullable. This fix addressed that by, in that case, targeting the innerType of the KtNullableType.
@mrmans0n mrmans0n mentioned this pull request Jun 9, 2023
Merged
github-merge-queue bot pushed a commit to slackhq/compose-lints that referenced this pull request Jun 9, 2023
@mrmans0n
Allow nullable types for trailing lambdas in ComposeParameterOrder (#134
eeb3989 
)

Fixed upstream in mrmans0n/compose-rules#61

Functional types weren't being taken into account when computing the desired order of parameters in composables when the function was nullable. This fix addressed that by, in that case, targeting the innerType of the KtNullableType.
@mrmans0n mrmans0n deleted the fix-nullable-trailing-for-param-order branch June 9, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComposableParamOrder shows error when trailing function is nullable without a default param
1 participant
@mrmans0n