fix: follow up unresolved PR76 security findings by mrkillbob · Pull Request #88 · mrkillbob/hermes-agent

mrkillbob · 2026-09-13T00:24:08Z

Summary

Follow-up to merged PR #76, based on current fork main 9e83df3634985a234e78aefa66e5ca321a08a3ff. This PR fixes the highest-risk coherent security/lifecycle subset and does not merge or modify PR84/PR85.

Fixed:

Secure worker and GitHub-feedback CI callbacks invoke Python with -P; admitted broker args and runtime args are kept consistent.
Completion hooks fail closed on missing decisions at the pre_kanban_complete boundary.
Kanban PR-creation detection blocks curl body forms (--data, --json, and short/equals variants).
Protected remote workers receive only the bounded terminal/file/web toolsets through the real CLI agent-construction path.
Foreground operator terminals preserve Git/GitHub auth/config inputs, while protected Kanban workers retain /dev/null Git config isolation.
Guardrail failure recording is fenced by worker run ID and claim lock at the DB update boundary.
Desktop quit no longer stops user-owned messaging gateways or creates a gateway drain-marker timeout path; only the Desktop-owned companion launchd job is stopped.

Validation

scripts/run_tests.sh changed Python slice: 352 tests passed before the final local-env assertion correction; the final targeted changed tests passed, including the new fencing/auth invariants.
Final targeted canonical runs: shell hooks, finalizer, secure worker/profile/CLI, protected remote worker, Kanban lifecycle, local environment auth boundary, and GitHub feedback callback tests all passed.
../../node_modules/.bin/vitest run --project electron electron/desktop-background-shutdown.test.ts: 2 passed.
npm run typecheck --workspace apps/desktop -- --pretty false: passed.
The full scripts/run_tests.sh tests/tools/test_approval.py run has one pre-existing unrelated failure in TestDetectDangerousRm.test_nonrecursive_verification_artifact_cleanup_is_not_dangerous; the new curl guard cases pass.
The full local-env file run was stopped after exceeding two minutes; its focused new invariants pass.

Remaining PR76 P1 findings

Not included because they are separate clusters or already fixed on current main:

Concurrent federation profile seeding; Kanban capacity/workspace ownership across boards; env-template matching.
Capability-registry enforcement lacks a live production specialist-dispatch caller; integrating it needs a caller/ownership design.
Bot Chat fleet-wide visibility reconciliation; rejected-review nudge behavior; Kanban event-stream cursor resume.
Voice fast-lane tool-free boundary.
Egress classifier split, Lunar City localization, and moving the narrative Vault connector out of core are separate refactors/policy work.
Optional Kanban route handling and dispatcher exported-boundary coverage are already fixed on current main.
Scheduled OSV SARIF upload condition is already fixed on current main.

No merge performed.

chatgpt-codex-connector · 2026-09-13T00:24:16Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-13T05:47:17.071100Z	`45cc235`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-09-13T00:24:48Z

૮ >ﻌ< ა ci review

_{ran on 45cc235 — fix: restore canonical vault progress import}

⚠️ Warnings

OSV vulnerability scan · View job

8 known vulnerabilities found in pinned dependencies.

CVE-2026-85062 in website/package-lock.json
CVE-2026-84369 in website/package-lock.json
CVE-2026-84368 in website/package-lock.json
CVE-2026-84373 in package-lock.json
CVE-2026-84373 in package-lock.json
CVE-2026-84367 in website/package-lock.json
GHSA-rgj7-g3m4-5g8c in scripts/whatsapp-bridge/package-lock.json
CVE-2026-84370 in website/package-lock.json

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.

debug info

CI timings

CI timings · View report · View job

Wall time 9m59s vs 10m42s (-6.7%). 11 job(s) slower, 12 faster, 2 unchanged.

Python tests / Run tests slice 8/8: -88.0s
Python tests / Run tests slice 7/8: +66.0s
Check no committed infographics / check-no-committed-infographics: -46.0s
OS-specific tests / Windows-only tests: +39.0s
JS & TS checks / JS & TS checks shard 2/5: -39.0s

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b1e7aa7b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35e45663c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebb84fa781

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 787a2d4453

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45cc23595f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector Bot reviewed Sep 13, 2026

View reviewed changes

Comment thread tools/approval.py Outdated

Comment thread tools/environments/local.py Outdated

Comment thread hermes_cli/cli_agent_setup_mixin.py

mrkillbob force-pushed the codex/pr76-p1-followup branch 2 times, most recently from eb7c55c to 9245e8b Compare September 13, 2026 01:16

chatgpt-codex-connector Bot reviewed Sep 13, 2026

View reviewed changes

mrkillbob force-pushed the codex/pr76-p1-followup branch 2 times, most recently from 186e392 to ebb84fa Compare September 13, 2026 04:28

chatgpt-codex-connector Bot reviewed Sep 13, 2026

View reviewed changes

Comment thread gateway/run_turn.py

Comment thread hermes_cli/federation.py

Comment thread plugins/github-pr-feedback/tests/test_cli.py

Comment thread gateway/progress_queries.py Outdated

mrkillbob force-pushed the codex/pr76-p1-followup branch 2 times, most recently from 59c8ddd to 787a2d4 Compare September 13, 2026 04:53

chatgpt-codex-connector Bot reviewed Sep 13, 2026

View reviewed changes

Comment thread apps/desktop/src/plugins/kanban/completion-notify.ts

Comment thread hermes_cli/federation.py

Comment thread plugins/platforms/discord/adapter.py

Comment thread plugins/platforms/discord/adapter.py

mrkillbob added 8 commits September 12, 2026 22:17

fix: follow up unresolved PR76 security findings

21b5964

fix: keep protected worker terminal credentials fenced

c71669f

fix: close remaining PR76 lifecycle boundaries

c608b0e

fix: keep vault reporting behind the plugin boundary

8b8b6be

style: satisfy kanban cursor lint

3ac7d74

fix: close remaining PR88 review threads

33b4fd6

fix: close PR93 follow-up review threads

fc725b5

fix: close PR88 follow-up review threads

3f0f4c9

mrkillbob force-pushed the codex/pr76-p1-followup branch from 787a2d4 to 3f0f4c9 Compare September 13, 2026 05:19

mrkillbob added 2 commits September 12, 2026 22:23

fix: satisfy cross-platform and plugin boundaries

203ccd8

fix: restore canonical vault progress import

45cc235

mrkillbob merged commit d54bd8b into main Sep 13, 2026
47 checks passed

mrkillbob deleted the codex/pr76-p1-followup branch September 13, 2026 05:44

chatgpt-codex-connector Bot reviewed Sep 13, 2026

View reviewed changes

Comment thread apps/desktop/src/plugins/kanban/api.ts

Comment thread tools/environments/local.py

Comment thread hermes_cli/federation.py

Comment thread plugins/platforms/discord/adapter.py

mrkillbob mentioned this pull request Sep 13, 2026

fix: resolve 27 findings from merged PR reviews #106

Merged

Conversation

mrkillbob commented Sep 13, 2026

Summary

Validation

Remaining PR76 P1 findings

Uh oh!

chatgpt-codex-connector Bot commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

github-actions Bot commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

૮ >ﻌ< ა ci review

⚠️ Warnings

OSV vulnerability scan · View job

debug info

CI timings · View report · View job

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Sep 13, 2026 •

edited

Loading

github-actions Bot commented Sep 13, 2026 •

edited

Loading