Adding support for http_proxy environment variable to be used for https #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mreinstein Hey Mike, any thoughts on this feature? |
|
@kyle-wrenn I have mixed feelings about the feature, but I'm not totally opposed to it either. I'd feel much better about the thing if there were unit tests that exercise this new functionality. |
|
@mreinstein I've added a couple of tests to simulate the presence of http_proxy environment variables. |
|
@kyle-wrenn would https://www.npmjs.com/package/global-tunnel solve your proxying related problems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.