Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: fix small typos #30049

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Node: fix small typos #30049

merged 1 commit into from
Dec 6, 2024

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Dec 6, 2024

Description

Fix small typos in src/node folder.

@Mugen87 Mugen87 added this to the r172 milestone Dec 6, 2024
@Mugen87 Mugen87 merged commit 04d8b8b into mrdoob:dev Dec 6, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98		 339.11
78.98		 +0 B
+0 B
WebGPU 484.85
134.59		 484.85
134.59		 +0 B
+0 B
WebGPU Nodes 484.31
134.5		 484.31
134.5		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04		 465
112.04		 +0 B
+0 B
WebGPU 554.24
150.04		 554.24
150.04		 +0 B
+0 B
WebGPU Nodes 510.12
139.75		 510.12
139.75		 +0 B
+0 B

@s-rigaud s-rigaud deleted the typos-node-comments branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87