fix: disconnect event listeners in InteractiveGroup #29975
+101
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it can be removed from the scene
bbsimong
commented
Nov 26, 2024
| listenToXRControllerEvents( controller ) { | ||
|
|
||
| this.controllers.push( controller ); | ||
| controller.addEventListener( 'move', this._onXRControllerEvent ); |
There was a problem hiding this comment.
I ported this over, but I don't think move is an actual XR event? It's not listed on the MDN https://developer.mozilla.org/en-US/docs/Web/API/XRSession/select_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed this when messing with the
InteractiveGrouputility. The event listeners are bound in thelistenTomethods, but they're not removed when the group is removed from the scene. I added adisconnectmethod which does this explicitly.As there's a
stopPropagationin the onPointerEvent, adding an interactive group to the scene and removing it later would prevent any of the pointer event listeners firing that were bound earlier.