PMREMGenerator: Add fromSceneAsync()
#29951
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29942
Description
Based on the PR we can see that the
webgl_animation_keyframes
example emits a lot of error messages that may not make much sense to the user and it doesn't load the IBL properly.This is because
PMREMGenerator
is being used without the WebGPU Backend being initialized. This PR aims to improve the error messages by guiding the user to replace functions likepmremGenerator.fromScene()
withpmremGenerator.fromSceneAsync()
.After this PR.
The user can fix it using: