Audio: Ensure progress is reset in onEnded()
.
#29930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
The
play
method of the audio object in Three.js sets the starting point based on the currentprogress
. Theprogress
is updated only when thepause
orstop
methods are called.Currently, when
pause
is executed during playback, theprogress
is set to the pause point. If the audio is played to the end from that point, theonEnded
event is triggered, and the audio stops. However, if playback is restarted after this, theonEnded
event does not update theprogress
. As a result, the audio restarts from the previouspause
point rather than the actual start of the audio.Proposed Solution:
This behavior is unintuitive and can lead to unexpected behavior. To resolve this issue, I modified the
onEnded
method to execute thestop
method, which ensures thatprogress
is updated correctly.ScreenShot
before
before.mp4
after
after.mp4