Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Add PointShadowNode #29849

Merged
merged 16 commits into from
Nov 21, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 8, 2024

Description

Implementation of PointShadowNode and revisions.

Live example

image

Copy link

github-actions bot commented Nov 8, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.13
79
339.13
79
+0 B
+0 B
WebGPU 478.76
132.73
482.43
133.72
+3.67 kB
+992 B
WebGPU Nodes 478.23
132.61
481.9
133.62
+3.67 kB
+1.01 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.59
111.96
464.59
111.96
+0 B
+0 B
WebGPU 546.92
148.18
550.49
149.19
+3.57 kB
+1 kB
WebGPU Nodes 502.8
137.9
506.37
138.9
+3.57 kB
+1 kB

@Spiri0
Copy link
Contributor

Spiri0 commented Nov 9, 2024

This looks very good even if the shadow cast is not yet correct

src/nodes/lighting/PointShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/PointShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/PointShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/PointShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/PointShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/ShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/ShadowNode.js Fixed Show fixed Hide fixed
src/nodes/lighting/ShadowNode.js Fixed Show fixed Hide fixed
@sunag sunag changed the title WebGPURenderer: Add PointShadowNode (WIP) WebGPURenderer: Add PointShadowNode Nov 21, 2024
@sunag sunag added this to the r171 milestone Nov 21, 2024
@sunag sunag marked this pull request as ready for review November 21, 2024 03:55
@sunag sunag merged commit 6394902 into mrdoob:dev Nov 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants