Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line2NodeMaterial: Fix broken dash. #29835

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Line2NodeMaterial: Fix broken dash. #29835

merged 1 commit into from
Nov 7, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 7, 2024

Fixed #28884.

Description

This PR fixes the broken dash by moving some of the computations to the vertex shader where they actually belong to. Besides, it makes sure dashOffset can be configured for LineDashedNodeMaterial.

@Mugen87 Mugen87 added this to the r171 milestone Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.22
171.45
692.22
171.45
+0 B
+0 B
WebGPU 825.22
222.85
825.32
222.86
+106 B
+16 B
WebGPU Nodes 824.33
222.64
824.44
222.66
+106 B
+16 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.58
112.26
464.58
112.26
+0 B
+0 B
WebGPU 545.43
147.71
545.49
147.75
+61 B
+36 B
WebGPU Nodes 501.37
137.44
501.37
137.44
+0 B
+0 B

@Mugen87 Mugen87 merged commit d2f7f08 into mrdoob:dev Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes: Line2NodeMaterial dash mode broken
1 participant