Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spherical: Use MathUtils.clamp() for makeSafe(). #29824

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Spherical: Use MathUtils.clamp() for makeSafe(). #29824

merged 1 commit into from
Nov 6, 2024

Conversation

linbingquan
Copy link
Contributor

@linbingquan linbingquan commented Nov 6, 2024 •
edited by Mugen87
Loading

Related issue: #29812

Description

As the title says.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.21
171.45		 692.2
171.45		 -16 B
-6 B
WebGPU 821.89
221.91		 821.87
221.9		 -16 B
-6 B
WebGPU Nodes 821
221.7		 820.99
221.7		 -16 B
-6 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.56
112.27		 464.56
112.27		 +0 B
+0 B
WebGPU 542.09
146.75		 542.09
146.75		 +0 B
+0 B
WebGPU Nodes 498.03
136.5		 498.03
136.5		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r171 milestone Nov 6, 2024
@Mugen87 Mugen87 changed the title src: Use MathUtils.clamp for Spherical.makeSafe Spherical: Use MathUtils.clamp() for makeSafe(). Nov 6, 2024
@Mugen87 Mugen87 merged commit 5d71052 into mrdoob:dev Nov 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r171
Development

Successfully merging this pull request may close these issues.
2 participants
@linbingquan @Mugen87