Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaterMesh: Fix planar offset - WebGPU #29626

Merged
merged 1 commit into from
Oct 11, 2024
Merged

WaterMesh: Fix planar offset - WebGPU #29626

merged 1 commit into from
Oct 11, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 11, 2024

Related issue: #29606 (comment)

Description

Now is possible better notice the normals maps too.

@sunag sunag added this to the r170 milestone Oct 11, 2024
@sunag sunag marked this pull request as ready for review October 11, 2024 15:34
@sunag sunag merged commit c3e812b into mrdoob:dev Oct 11, 2024
11 checks passed
@sunag sunag deleted the dev-fix-water branch October 11, 2024 15:47
@mrdoob
Copy link
Owner

mrdoob commented Oct 12, 2024

Hmm... Is this a bug in Chrome Android? 🤔

https://raw.githack.com/mrdoob/three.js/dev/examples/index.html?q=webgpu#webgpu_ocean

screen-20241012-090916.mp4

@Makio64
Copy link
Contributor

Makio64 commented Oct 12, 2024

Bug on chrome iOS (webgl backend )

ScreenRecording_10-12-2024.07-27-31_1.mov

Bug on safari iOS (webgpu enabled flag)
https://github.com/user-attachments/assets/16a7f7ad-904f-4a6b-893a-8bf2a6b9887e

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 12, 2024

@mrdoob I'm seeing this on a Pixel 8a and Chrome as well. But not on other devices.

@Makio64 I can reproduce this with Firefox and macOS, too. It works with Safari+WebGPU but not Safari+WebGL.

@sunag
Copy link
Collaborator Author

sunag commented Oct 13, 2024

Here work properly!

  • Samsung Galaxy Z Flip 4
  • Chrome 129.0.6668.
  • Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants