Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutlineNode: Improve approach #29583

Merged
merged 2 commits into from
Oct 8, 2024
Merged

OutlineNode: Improve approach #29583

merged 2 commits into from
Oct 8, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 8, 2024

Related issue: #29575

Description

Pretty much all we need from outline() is the visibleEdgeand the hiddenEdge, and to control the thickness and glow, all other nodes parameters should be derived from external node so that the user can expand the customization possibilities without affecting performance and complexity.

const { visibleEdge, hiddenEdge } = outline( scene, camera );

@sunag sunag marked this pull request as ready for review October 8, 2024 03:28
@sunag sunag added this to the r170 milestone Oct 8, 2024
@sunag sunag merged commit 1ae4fce into mrdoob:dev Oct 8, 2024
11 checks passed
@sunag sunag deleted the dev-outline branch October 8, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants