Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screenshot on Windows #28306

Closed
wants to merge 1 commit into from
Closed

Make screenshot on Windows #28306

wants to merge 1 commit into from

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 7, 2024

Related issue: #28296

@ycw ycw mentioned this pull request May 7, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented May 7, 2024

As expected the tests fail, sometimes with very large diffs. Since the examples have not been changed visually, the diff must be related to setAnimationLoop(). I suspect the usage of setAnimationLoop() is maybe not 100% deterministic. The original fix for requestAnimationFrame() does not work anymore, see https://github.com/mrdoob/three.js/blob/dev/test/e2e/deterministic-injection.js.

@Mugen87
Copy link
Collaborator

Mugen87 commented May 7, 2024

@ycw Thanks for filing the PR and confirming the failure!

@Mugen87 Mugen87 closed this May 7, 2024
@ycw
Copy link
Contributor Author

ycw commented May 7, 2024

my pleasure

@ycw ycw deleted the make-screenshot branch January 14, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants