Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderLib: Clean up #27936

Merged
merged 1 commit into from
Mar 18, 2024
Merged

ShaderLib: Clean up #27936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderers/shaders/ShaderLib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const ShaderLib = {
emissive: { value: /*@__PURE__*/ new Color( 0x000000 ) },
roughness: { value: 1.0 },
metalness: { value: 0.0 },
envMapIntensity: { value: 1 } // temporary
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I market this as 'temporary' in the original MeshStandardMaterial PR (#7381) because I felt the environmant map intensity should be a property of the environment map, not the material.

But it has turned out not to be temporary after all...

envMapIntensity: { value: 1 }
}
] ),

Expand Down