Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFExporter: Restore multi material support for non-indexed geometries. #27268

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 28, 2023

Fixed #21538.

Description

When the forceIndices flag was removed via #19113, a code section was deleted that ensured group data were honored of non-indexed geometries. This PR restores the original code from #13536 which means a temporary index is created so the primitive generation works as expected.

@danielealbano With this PR in place, I was able to correctly export the problematic zombie FBX asset from #27259 to glTF. This is how it looks like in Don's viewer:

image

@Mugen87 Mugen87 added this to the r159 milestone Nov 29, 2023
@Mugen87 Mugen87 merged commit 1b4dff0 into mrdoob:dev Nov 30, 2023
11 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLTFExporter does not honor groups with non-indexed geometry.
1 participant