WebGLRenderer: Add targetScene
parameter to compile()
methods.
#26966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #19752
Description
This PR implements the feedback from #19752 (comment) and introduces the
targetScene
parameter, which was part of the original version of #19752.@toji I've managed to refactor the code such that
compileAsync()
reuses the implementation fromcompile()
which makes the code more manageable. Do you think your use case will work with this version ofcompileAsync()
?BTW: Existing usage of
compile()
should not be affected by this change.targetScene
is optional.