Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Introduce asyncShaderCompilation flag. #26964

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/renderers/WebGLRenderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ class WebGLRenderer {
onShaderError: null
};

// shader compilation

this.asyncShaderCompilation = false;

// clearing

this.autoClear = true;
Expand Down Expand Up @@ -785,6 +789,8 @@ class WebGLRenderer {

const program = setProgram( camera, scene, geometry, material, object );

if ( program === null ) return;

state.setMaterial( material, frontFaceCW );

//
Expand Down Expand Up @@ -1902,6 +1908,14 @@ class WebGLRenderer {

}

if ( _this.asyncShaderCompilation === true ) {

// check if the shader program can be already used for rendering.

if ( program.isReady() === false ) return null;

}

let refreshProgram = false;
let refreshMaterial = false;
let refreshLights = false;
Expand Down