-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSShadowPass (screen space shadow) #21951
base: dev
Are you sure you want to change the base?
Conversation
Another branch that trying to use Demo: https://raw.githack.com/gonnavis/three.js/SSLightPass/examples/webgl_postprocessing_ssshadow.html |
Hey @gonnavis, this is a cool technique, are you still working on it? Is there any way I could contribute? |
Hello @lyonsno, currently it lacks a lot of feature, such as:
But recently I may have not enough time and ability to do all these. |
|
||
}; | ||
|
||
var SSShadowDepthShader = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this declared using var
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's copy-pasted from old SSRShader.js, should be ok with let
const
.
SSShadowPass looks amazing, I would like to use this in Fciv.net to implement shadows. I therefore hope this could be merged and included in the next Three.js release please. https://github.com/fciv-net/fciv-net |
@andreasrosdal Thanks! I'll try to ship a basic version first. |
Related:
https://twitter.com/mrdoob/status/1400345686537916418
https://twitter.com/BrianKaris/status/1283513723852689409
Description:
Made a quick prototype of SSShadowPass (screen space shadow), I'll keep improving.
---EDIT---
![image](https://user-images.githubusercontent.com/10785634/121063437-e0119e80-c7f8-11eb-988a-2117af003aba.png)
Demo: https://raw.githack.com/gonnavis/three.js/SSShadowPassPr/examples/webgl_postprocessing_ssshadow.html