Global: Remove references to examples/js. #18743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
ok sorry, do i need to remove it here also? |
|
I'll mark it as off-topic to avoid confusion. |
|
ok man
…On Wed, Mar 4, 2020, 16:09 Michael Herzog ***@***.***> wrote:
I'll mark it as off-topic to avoid confusion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18743?email_source=notifications&email_token=AI72Q6MT6VPKH3MXBDI2WB3RFYLETA5CNFSM4K4BLIQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENW6RYI#issuecomment-594405601>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI72Q6JLYZRNFQFIMDBWJKTRFYLETANCNFSM4K4BLIQA>
.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes references to
examples/jsfrom the code base and docs. Besides, the code examples now assume that example files were imported via modules and thus are not in theTHREEnamespace anymore.This PR is a preparation to deprecate
examples/js.