Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove glTF Rigged Simple model #13583

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Remove glTF Rigged Simple model #13583

merged 2 commits into from
Mar 13, 2018

Conversation

takahirox
Copy link
Collaborator

This PR removes glTF Rigged Simple model which seems no longer necessary. #13571

BTW, I think we can also remove Outlined Box model. (What's this model for?) What do you think?

donmccurdy
donmccurdy approved these changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would keep OutlineBox for now, since it’s our only example using a draw mode other than triangles I think.

@takahirox
Copy link
Collaborator Author

I would keep OutlineBox for now, since it’s our only example using a draw mode other than triangles I think.

OK. Yeah it seems using line (for outline?).

@mrdoob mrdoob added this to the r91 milestone Mar 13, 2018
@mrdoob mrdoob merged commit 9c4cc03 into mrdoob:dev Mar 13, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.
3 participants
@takahirox @mrdoob @donmccurdy