Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Added preview for MeshPhysicalMaterial #13564

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Docs: Added preview for MeshPhysicalMaterial #13564

merged 1 commit into from
Mar 13, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 11, 2018

I've noticed that the material preview for MeshPhysicalMaterial was missing.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 11, 2018

https://rawgit.com/Mugen87/three.js/dev8/docs/index.html#api/materials/MeshPhysicalMaterial

@WestLangley
Copy link
Collaborator

MeshPhysicalMaterial and MeshStandardMaterial were designed to be used with an environment map so there is something to reflect. They were not designed to support refraction.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 11, 2018

I've just added a similar setup that is already in place for MeshStandardMaterial. I don't have the intention to rework both previews. Let's do this in a different PR.

@mrdoob mrdoob added this to the r91 milestone Mar 13, 2018
@mrdoob mrdoob merged commit d77214a into mrdoob:dev Mar 13, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @WestLangley @mrdoob