OBJLoader2 V2.4.0: Parser polishing, ArrayBuffer handling (#13197), LoaderSupport clean-up #13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- three.js issue 13197: - Added forceWorkerDataCopy to THREE.LoaderSupport.WorkerSupport and THREE.LoaderSupport.WorkerDirector - THREE.OBJLoader2 handles cached resources properly. This increases overall performance as no unnecessary reloads are requested. - THREE.OBJLoader2: Reduced Parser complexity: - Simplified slash counting used for face type detection - One buildFace fucntion is used for all four face types, lines and points including indices (=vertex reduction) creation if wanted. - String processing (o, g, mtllib and usemtl) just concatenates chars - Overall speed improvements due simpler code paths - Removed THREE.LoaderSupport.ConsoleLogger: Added setLogging function as replacement where. Console logging is behind boolean flags. - Removed THREE.LoaderSupport.LoaderBase: Many functions are coupled with OBJLoader2. It was simply not generic enough and added unneeded complexity. - Reduced THREE.LoaderSupport.PrepData to minimum set of generic functions. Simple properties are added by demand and are no longer enforced. - Renamed THREE.LoaderSupport.Builder to THREE.LoaderSupport.MeshBuilder - Updated documentation
5 tasks
|
Looking good! |
|
I'll merge now. Planning on releasing next week so we have some time to test. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the things addressed:
@mrdoob Existing examples, verify.obj and gathered OBJ models during bug-fixing are looking good. There are no obvious regressions. Performance was slightly improved, especially parallel usage. OBJ Parser code is really condensed now and I hope it is easier to follow and understand for others.
This represents an intermediate step. My idea for the future: Make OBJLoader2 independent of LoaderSupport. LoaderSupport or pieces of it and parts of OBJLoader2 become generic WorkerLoader. OBJLoader2 replaces OBJLoader. Of course, this requires further discussions and prototyping (R92 seems a good candidate, I personally would like to speed up things more, but this is a spare time activity, currently 😊 )