Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTexture: Refactored generateMipmaps usage. #13521

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Mar 7, 2018

The current implementation crashed when the code tried to generate mipmaps for a WebGLRenderTarget because rendertarget.texture.image is undefined and the code was looking for rendertarget.texture.image.width.

FYI @takahirox

@mrdoob mrdoob added this to the r91 milestone Mar 7, 2018
@mrdoob mrdoob merged commit a92b98b into dev Mar 7, 2018
@mrdoob mrdoob deleted the generateMipmaps-refactor branch March 7, 2018 21:57
@takahirox
Copy link
Collaborator

Thanks! If we had auto regression test, we could easily find this issue before merging.

@mrdoob
Copy link
Owner Author

mrdoob commented Mar 7, 2018

I heard @fernandojsg is working on it 😊

@mrdoob
Copy link
Owner Author

mrdoob commented Mar 7, 2018

However, the real problem is that WebGLTextures is a mess... 😕

@takahirox
Copy link
Collaborator

Agreed. I had a hard time adding maxMipLevel because WebGLTextures is a bit complex. We need WebGLTextures refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants