Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColladaLoader: Better support of textured/non-textured materials #13490

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 4, 2018

This PR should fix #3803. The uv buffer attribute is now consistent to other attributes of the geometry.

I'm not 100% happy with the implementation because it seems a bit hacky. However, i can't think of a cleaner approach.

@mrdoob mrdoob added this to the r91 milestone Mar 7, 2018
@mrdoob mrdoob merged commit 799f87a into mrdoob:dev Mar 7, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColladaLoader fails with objects containing mixture of textured and non-textured materials
2 participants