Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicDepthPacking: white nearest #13480

Merged
merged 1 commit into from
Mar 3, 2018
Merged

BasicDepthPacking: white nearest #13480

merged 1 commit into from
Mar 3, 2018

Conversation

WestLangley
Copy link
Collaborator

Fixes #13329.

@WestLangley
Copy link
Collaborator Author

I made what I think are the correct mods to the SAO code. It looks good, anyway!

/ping @Ludobaka
/ping @bhouston

@mrdoob mrdoob added this to the r91 milestone Mar 3, 2018
@mrdoob mrdoob merged commit 4db05d9 into mrdoob:dev Mar 3, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 3, 2018

Thanks!

@WestLangley
Copy link
Collaborator Author

I was not able to get the God-rays example to work properly. That example is 6 years old. Perhaps someone is interested in updating it...

@WestLangley
Copy link
Collaborator Author

Merged in 24 seconds after posting. That has got to be a record! :)

@WestLangley WestLangley deleted the dev-white_nearest branch March 3, 2018 01:51
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 3, 2018

What about: https://threejs.org/examples/webgl_depth_texture.html

It is still "black nearest" in this case. Do we need a change here?

@WestLangley
Copy link
Collaborator Author

@Mugen87 Might as well... I'll fix. Thanks.

@WestLangley WestLangley mentioned this pull request Mar 3, 2018
Merged
@Mugen87 Mugen87 mentioned this pull request Apr 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @mrdoob @Mugen87