Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferAttribute: Define default callback function on prototype instead of in constructor #13467

Merged
merged 1 commit into from
Mar 1, 2018
Merged

BufferAttribute: Define default callback function on prototype instead of in constructor #13467

merged 1 commit into from
Mar 1, 2018

Conversation

aardgoose
Copy link
Contributor

Matches Object3D and is more efficient

@aardgoose
Copy link
Contributor Author

InterleavedBuffer and Loader also could have this change made if this one is OK

@mrdoob mrdoob added this to the r91 milestone Mar 1, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2018

Nice!

@mrdoob mrdoob merged commit da3e02d into mrdoob:dev Mar 1, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2018

Thanks!

@aardgoose aardgoose deleted the callback-on-prototype branch March 2, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.
2 participants
@aardgoose @mrdoob