-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFExporter Doc: Update for new options #13433
Conversation
@@ -80,7 +80,9 @@ <h3>[method:null parse]( [param:Object input], [param:Function onCompleted], [pa | |||
<li>truncateDrawRange - bool. Export just the attributes within the drawRange, if defined, instead of exporting the whole array. Default is true.</li> | |||
<li>binary - bool. Export in binary (.glb) format, returning an ArrayBuffer. Default is false.</li> | |||
<li>embedImages - bool. Export with images embedded into the glTF asset. Default is true.</li> | |||
<li>animations - Array<[page:AnimationClip AnimationClip]>. List of animations to be included in the export. | |||
<li>animations - Array<[page:AnimationClip AnimationClip]>. List of animations to be included in the export.</li> | |||
<li>forceIndices - bool. Generate indices for non-index geometry and export with it. Default is false.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the wording here, maybe "with them"? Or Export non-indexed geometry by creating temporary indices for it
? /cc @mrdoob @donmccurdy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Replaced "it" with "them" so far.
I don't think I would document these. As they're just temporal workarounds for Facebook 3D posts...? |
Will we remove them once FB fixes the limitations? |
I hope so. At least the |
I believe |
I wanna add note "These're temporal workarounds for FB" to Doc (or in the code) rather than non documenting. |
Okay, lets remove when they're not needed then. |
Thanks! |
This PR updates
GLTFExporter
doc for new options and fixes a minor stuff.