Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColladaLoader: instance node names now match their associated library nodes name #13432

Merged
merged 1 commit into from
Feb 25, 2018
Merged

ColladaLoader: instance node names now match their associated library nodes name #13432

merged 1 commit into from
Feb 25, 2018

Conversation

shelbyspeegle
Copy link
Contributor

@shelbyspeegle shelbyspeegle commented Feb 25, 2018

Fixes #13365

@mrdoob mrdoob changed the title ColladaLoader - #13365 instance node names now match their associated… ColladaLoader: instance node names now match their associated library nodes name Feb 25, 2018
@mrdoob mrdoob added this to the r91 milestone Feb 25, 2018
@mrdoob mrdoob merged commit 0e44cfd into mrdoob:dev Feb 25, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2018

Thanks!

@thedayofcondor
Copy link

Hi,
just updated my project from r87 to r100 and the updated ColladaLoader does not seem to load my model correctly anymore . My model is generated with SketchUp 2018.

In my opinion the original behavious was correct, allowing an instance to have a separate name from the library node (this is the intended behaviour, having a separate "name" property in the node).

As a suggestion, what about allowing a node to have a "name" and an "instanceName" (or a "name" and a "libraryName")?

@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2019

@thedayofcondor It'll be better to create a new issue for this. Please, provide a example file if possible.

@thedayofcondor
Copy link

thedayofcondor commented Jan 28, 2019

@mrdoob thank you, I created #15658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants