-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DirectGeometry: clone bounding volumes in fromGeometry method #13428
Conversation
I do not think it makes sense to add these methods here.
|
@WestLangley You are right, of course the code of |
I understand. I guess @mrdoob will make the design decision. Thank you for pointing out these issues. :) |
@WJsjtu I would focus on bounding volumes in this PR. If you like, you can remove |
0e0f5dd
to
9b71b63
Compare
Hmm... I'm not sure |
They are copied in three.js/src/core/BufferGeometry.js Lines 573 to 583 in 0c6c005
|
Oh, there you go. I should have named that variable |
@mrdoob I think it's okay to merge this fix for consistency reasons. |
Thanks! |
See #13420 for detail.
@Mugen87 The doc may need to be fixed, but I'm not sure whether to remove all the information about
EventDispatcher
in it or to makeDirectGeometry
extendEventDispatcher
and adddispose
method ( likeBufferGeometry
andGeometry
).As I mentioned in PR 13420, The same code may need to be added in
BufferGeometry.updateFromObject
for Mesh and Points.