Fix camera transforms in VR #13414
Fix camera transforms in VR #13414
Conversation
src/renderers/webvr/WebVRManager.js
Outdated
|
|
||
| } else { | ||
|
|
||
| standingMatrix.makeTranslation( 0, scope.userHeight, 0 ); |
There was a problem hiding this comment.
Not using userHeight anymore is intentional?
There was a problem hiding this comment.
The diff is misleading. This if block was moved up to line 113
There was a problem hiding this comment.
I see the standingMatrix and scope.userHeight is accounted for above. If position is null I think this else branch would reset the height back to 0 overriding the scope.userHeight, doesn’t it?
There was a problem hiding this comment.
Ah, you're right. Good catch.
There was a problem hiding this comment.
Removing the else would do I think
|
This also fixes the transform of objects attached to the camera. E.g. the crosshair in the webvr_cubes example. |
|
I just tested on Vive and I cannot reproduce the culling issues. @brianpeiris 🏅 |
|
Thanks! |
|
I just tested this fix with my own A-Frame / Three.js app where I started to see clipping issues for the right eye on Oculus Rift after updating to A-Frame 0.8.1 / Three.js r90. When using latest version from mrdoob#dev where this has PR been merged in, I unfortunately still have exactly the same clipping issue for the right eye as before. So this PR hasn't fixed the issue for me, but I unfortunately lack the detailed knowledge of how transforms and culling works to fix it myself. Anything I can do to help to fully resolve this issue? |
|
@RSpace Do you have a link to repro? |
|
@brianpeiris Your PR solved the problem of objects being incorrectly culled due to the bad construction of the camera matrix. The issue described in #13236 has been always present since the VR logic switched to use just the left eye frustum for culling. Any example should reproduce the problem where objects are incorrectly culled on the right side of the right eye field of view. More info on aframevr/aframe#3488 |
|
Ah, thanks for clearing that up. |
Fixes #13236