SAOPass: Fix use of multiple instances #13399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Mugen87
requested changes
Feb 22, 2018
| @@ -74,7 +74,12 @@ THREE.SAOPass = function ( scene, camera, depthTexture, useNormals, resolution ) | |||
|
|
|||
| } | |||
|
|
|||
| this.saoMaterial = new THREE.ShaderMaterial( THREE.SAOShader ); | |||
| this.saoMaterial = new THREE.ShaderMaterial( { | |||
| defines: THREE.SAOShader.defines, | |||
There was a problem hiding this comment.
As i said in #13370 (comment), it is also necessary to clone the defines object because the respective values can differ from pass to pass. If you would use different camera types (perspective vs. orthographic) in your two scenes, it would be a problem. The following code should fix it:
defines: Object.assign( {}, THREE.SAOShader.defines ),There was a problem hiding this comment.
oh, thought your code was already the complete one^^
There was a problem hiding this comment.
inserted the line of code ;)
|
Looks good now! |
Mugen87
approved these changes
Feb 22, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #13370