Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimationAction: Fix LoopRepeat #13374

Merged
merged 2 commits into from
Feb 20, 2018
Merged

AnimationAction: Fix LoopRepeat #13374

merged 2 commits into from
Feb 20, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 20, 2018 •
edited
Loading

This PR should solve #13011

@gero3's test fiddle executes now only three times as you would expect.

@donmccurdy
Copy link
Collaborator

There is a note in the AnimationAction docs that can be removed now:

Note: The first run is not taken into account. For example: if repetition is set to 2, the total number of executed rounds will be 3.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 20, 2018

Done! 👍

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 20, 2018

Reminder: Add this change to the migration guide 😊

@mrdoob mrdoob added this to the r91 milestone Feb 20, 2018
@mrdoob mrdoob merged commit 545c587 into mrdoob:dev Feb 20, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 20, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @donmccurdy @mrdoob