-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add renderer prop in onBeforeCompile #13362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or could be this: material.onBeforeCompile( materialProperties.shader, _this ); |
I think I vote for that instead. |
Done! |
Mugen87
approved these changes
Feb 28, 2018
I think there should be an update to the documentation when a method's signature is changed. |
Is to change it [method:null onBeforeCompile]() to? [method:null onBeforeCompile]( [param:Object shader], [param:WebGLRenderer renderer] ) |
@sunag yep! |
Done |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My need:
To the next
NodeMaterial
release is needrenderer
argument to build material. Not to complicate too much the idea is use an auto build since theonBeforeCompile
is called.Renderer argument is the first moment to texture
encoding
. Now is individual by texture and not by slot as previously, for example:Old
New
And fix the fact that the old mode only work with linear texture encoding in
NodeMaterial
.