Transform controls vs transparency vs fog #13344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Feb 16, 2018
| @@ -134,6 +136,9 @@ | |||
|
|
|||
| object.name = name; | |||
|
|
|||
| //always render on top of the scene (avoid being hidden by transparent objects) | |||
| object.renderOrder = Infinity; | |||
There was a problem hiding this comment.
Setting renderOrder to Infinity does not cause an object to be rendered "on top".
This only works in this case because of the depthTest = false, depthWrite = false and transparent = true material settings.
You can either remove the comment, or change it to
// avoid being hidden by other transparent objects
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transform controls gizmo currently receives fog and can be hidden by other transparent objects. This PR disables the fog in its materials and puts the
renderOrderof its lines and meshes toInfinity.