Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColladaLoader: Improve parsing of distance unit #13338

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 15, 2018

This PR solves one problem of #13335

The meter property of the unit tag is optional. If it is not set, you have to use the default value of 1 according to the spec (see <asset> element).

@mrdoob mrdoob added this to the r91 milestone Feb 15, 2018
@mrdoob mrdoob merged commit 7d6c925 into mrdoob:dev Feb 15, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 15, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants