Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferGeometry: honor groups in toNonIndexed() #13217

Merged
merged 1 commit into from
Feb 26, 2018
Merged

BufferGeometry: honor groups in toNonIndexed() #13217

merged 1 commit into from
Feb 26, 2018

Conversation

WestLangley
Copy link
Collaborator

I was a bit surprised that, when converting from indexed-geometry to non-indexed-geometry, the groups do not need to be changed. Apparently it is true.

/ping @Mugen87 for 2nd opinion, please

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 31, 2018 •
edited
Loading

Looks good. The amount of drawn triangles does not change if we use drawElements() instead of drawArrays(). So group (index) data should be identical.

@mrdoob mrdoob added this to the r91 milestone Feb 1, 2018
@WestLangley
Copy link
Collaborator Author

/ping @mrdoob

@mrdoob mrdoob merged commit 605f502 into mrdoob:dev Feb 26, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 26, 2018

Thanks!

@WestLangley WestLangley deleted the dev-groups branch February 26, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @Mugen87 @mrdoob