GLTFExporter Fix Morph #12967
Merged
GLTFExporter Fix Morph #12967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Dec 25, 2017
| @@ -800,9 +800,41 @@ THREE.GLTFExporter.prototype = { | |||
|
|
|||
| for ( var attributeName in geometry.morphAttributes ) { | |||
|
|
|||
| // glTF 2.0 morph supports only POSITION/NORMAL/TANGENT. | |||
| // | |||
| // @TODO TANGENT support | |||
There was a problem hiding this comment.
TBH I wouldn't bother adding a @\TODO about this since three.js doesn't support stored tangents currently...
|
|
||
| var baseAttribute = geometry.attributes[ attributeName ]; | ||
| // Clones attribute not to override | ||
| var attribute2 = attribute.clone(); |
There was a problem hiding this comment.
nit: could you rename this relativeAttribute or something like that? Comment above it wouldn't be necessary in that case.
|
Updated. Thanks for the comments. Regarding absolute/relative comment, let me keep it because I think it'll be helpful for new developers. |
|
/ping @fernandojsg for the review |
|
Sorry, I lost track of this PR. I'll merge for now, we can amend if @fernandojsg has any comments. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
GLTFExporterMorph.You can see that the second one fixes a morph issue on Don's glTF viewer
https://gltf-viewer.donmccurdy.com/
Without this change scene.zip
With this change scene_fix.zip
Zip files include glTF AnimationMorphCube model loaded with
GLTFLoaderand then exported withGLTFExporterhttps://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/AnimatedMorphCube
/cc @fernandojsg @donmccurdy