Remove optionalTarget - part 1 #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Dec 5, 2017
|
I think we should go through this change. |
|
Looks good, but warnings are intented to be remove in future release, no ? So maybe a comment ( or better a todo ) like:
Could be usefull ! And finally, when it will be removed the methods will become unprotected... again... See last comment in #12231 |
|
/ping @mrdoob |
|
Ops! Sorry, I started losing track of issues at the end of last year. That's why I started using milestones. If there are pending issues that haven't been added to a milestone, please do me a /ping on it 😅 |
|
@WestLangley Any chance you can merge |
|
Done! Well that was a bit tedious... Hopefully no mistakes... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #12231.
Implemented just a few classes at first to see if this is going to be acceptable...