Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitControls example: modify scene #12742

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Conversation

WestLangley
Copy link
Collaborator

Make the scene a bit more OrbitControls-compatible.

@clement-igonet
Copy link

From my point of view, a convenient "panning" would be to have a move parallel to your pyramid ground. It's like if the ground were sliding, in a parallel move relative to itself.
So, orbital move should not change height of your sphere center
I would add axes representation to help the understanding.
In that way, you should not be able to move the camera under the pyramid ground.

@WestLangley
Copy link
Collaborator Author

a convenient "panning" would be to have a move parallel to your pyramid ground

Agreed. That is how OrbitControls panning should have been implemented. Currently, OrbitControls pans in screen-space, just like TrackballControls.

The suggested panning method is set as the default in an upcoming re-write of the class.

@clement-igonet
Copy link

clement-igonet commented Nov 25, 2017 via email

@WestLangley
Copy link
Collaborator Author

That will not be necessary.

@clement-igonet
Copy link

clement-igonet commented Nov 26, 2017 via email

@WestLangley
Copy link
Collaborator Author

OrbitControls is not part of the library -- it is part of the examples. Users are free to modify the class as they see fit.

@clement-igonet
Copy link

clement-igonet commented Nov 26, 2017 via email

@clement-igonet
Copy link

clement-igonet commented Dec 23, 2017

I've suggest a fix for panUp move here: #12727.
Demo here.
What do you think ?

@mrdoob mrdoob added this to the r91 milestone Feb 16, 2018
@mrdoob mrdoob merged commit c51a7d8 into mrdoob:dev Feb 16, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 16, 2018

Thanks!

@WestLangley WestLangley deleted the dev-orbit branch February 17, 2018 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants