-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrbitControls example: modify scene #12742
Conversation
From my point of view, a convenient "panning" would be to have a move parallel to your pyramid ground. It's like if the ground were sliding, in a parallel move relative to itself. |
Agreed. That is how The suggested panning method is set as the default in an upcoming re-write of the class. |
Good to hear you understand me 😀 Do you want me to suggest an implementation ?
--
Sent from my mobile. It explains my brevity.
|
That will not be necessary. |
From my point if view, panning is out of scope. It extends orbit control, but it is not orbit control.
And also, its implementation is finally too dependent on object (a plan) into the scene.
Imagine the case of a planet navigation: we would like to rotate a sphere rather than to slide a plan.
I would suggest to let to the user the ability to implement his/her own extended control relative to his/her context.
So, pan() function could be externally defined if needed. It's what I tried to do in a "monkey" style. 😀
|
|
OK.
However, all webgl examples rely on OrbitControls "example"... :-)
That's why I suggest to consider that OrbitControls improvement has high value.
I guess also that examples could become part of core lib if well done.
So improvement is welcome.
|
Thanks! |
Make the scene a bit more
OrbitControls
-compatible.