[gltf] Fix parsing of Bone nodes. #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: KhronosGroup/glTF#1020 /cc @takahirox |
|
@takahirox looks good? |
lexaknyazev
reviewed
Jun 17, 2017
examples/js/loaders/GLTF2Loader.js
Outdated
| // Nothing in the node definition indicates whether it is a Bone or an | ||
| // Object3D. So, traverse the hierarchy once in advance, using node.skins | ||
| // references to mark bones. | ||
| nodes.forEach( function ( node ) { |
There was a problem hiding this comment.
@donmccurdy
Why do you traverse all nodes and check each for skin? It would be faster to traverse skins directly:
skins.forEach( function ( skin ) {
if ( skin.joints !== undefined ) {
skin.joints.forEach( function ( id ) {
nodes[ id ].isBone = true;
} );
}
} );There was a problem hiding this comment.
Good point, thanks! 😆
donmccurdy
force-pushed
the
bug-gltf2-node-bones
branch
from
ff50ff1
to
0fd9391
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun fact: apparently all the animated examples still work if their bones are turned to
Object3D.But SkeletonHelper is less happy, so this fixes that.