Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gltf] Use opaque alpha mode by default. #11498

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

donmccurdy
Copy link
Collaborator

See: KhronosGroup/glTF-Sample-Viewer#20

@takahirox it sounds like transparency in PNGs should be ignored by default, and only applied if the alphaMode is set to something other than OPAQUE.

Before After
screen shot 2017-06-12 at 7 45 52 pm screen shot 2017-06-12 at 7 45 42 pm

^Fins are should be opaque, in this example, because alphaMode is not set at all, and defaults to OPAQUE.

@mrdoob
Copy link
Owner

mrdoob commented Jun 13, 2017

Thanks!

@cx20
Copy link
Contributor

cx20 commented Jun 13, 2017

I tried trying the latest version of Three.js + glTF Loader, However, the following error occurred.

THREE.PropertyBinding.sanitizeNodeName is not a function

I think that it is a temporary problem and I want to test it when the main body is rebuilt.

@donmccurdy
Copy link
Collaborator Author

@cx20 The latest change (fixing some animated models created with the Blender exporter) required changes in three.js core. So to test, you'll need the latest version of three.js from the dev branch.

Well, that or a monkeypatch for the issue, THREE.PropertyBinding.sanitizeNodeName = (n) => n;

@cx20
Copy link
Contributor

cx20 commented Jun 13, 2017

I was able to confirm the fix by applying the monkeypatch.
Three.js r86dev + glTF Loader result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants